Skip to content

Remove intrinsic min-width of fieldset#272

Closed
vanthome wants to merge 2 commits intonecolas:masterfrom
vanthome:master
Closed

Remove intrinsic min-width of fieldset#272
vanthome wants to merge 2 commits intonecolas:masterfrom
vanthome:master

Conversation

@vanthome
Copy link
Contributor

At least Firefox [1] and Chrome [2] have a legacy/ intrinsic min-width
for the fieldset element.
This removes it. The fix is especially useful on mobile.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=504622
[2] http://stackoverflow.com/questions/8084343/google-chrome-fieldset-overflow-bug

normalize.css Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be in alphabetical order

@necolas
Copy link
Owner

necolas commented Jan 11, 2014

Please squash into a single commit. You can force-push to your remote branch rather than creating another pull request.

At least Firefox [1] and Chrome [2] have a legacy/ intrinsic min-width
for the fieldset element.
This removes it. The fix is especially useful on mobile.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=504622
[2]
http://stackoverflow.com/questions/8084343/google-chrome-fieldset-overflow-bug
@vanthome
Copy link
Contributor Author

Like this?

@necolas
Copy link
Owner

necolas commented Jan 12, 2014

Yep, thanks! Needs a test in the test.html file too please.

test for the `min-width: 0` rule.
Test with for example with Chrome by making
the window as narrow as possible.
@vanthome
Copy link
Contributor Author

I've added a small test although the existing fieldsets would have been enough to demonstrate the problem.

@necolas necolas closed this in 6992935 Jan 15, 2014
@necolas
Copy link
Owner

necolas commented Jan 25, 2014

This doesn't seem to fix Firefox. Will probably revert this.

@vanthome
Copy link
Contributor Author

Ok, you confirmed what I found out in my last test, I was sure that it fixes also FF but at least with 26 it isnt.
If you look at the referenced bugreport of FF, it's not yet fixed although its from 2010. Someone says that adding display:table-column; would help. Shall we try this?

@necolas
Copy link
Owner

necolas commented Jan 25, 2014

None of the table displays works without side-effects. Doesn't seem to be much we can do to work around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants