Open
Conversation
JzfL
suggested changes
Apr 30, 2025
JzfL
left a comment
There was a problem hiding this comment.
Good SQL! please try complete section 1 of assignment 2
JzfL
approved these changes
Apr 30, 2025
JzfL
left a comment
There was a problem hiding this comment.
OK I see, your assignment 2 ERD was already in main branch, good job
However, for future DSI modules as well as at future work place, please have your PR contain all the changes
Owner
Author
|
Thanks, I just noticed that and uploaded that under the assignment_two branch.
I will remember it for the next time.
… On Apr 29, 2025, at 11:34 PM, JzfL ***@***.***> wrote:
@
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added scripts as requested for Assignment 2.
What did you learn from the changes you have made?
One good thing I learned from SQL for Dummies book is that I can set an alias for referring to a table and use that in the script like when we right FROM vendor_inventory vi we can use vi instead of vendor_inventory and that makes the script shorter and cleaner. This is same in SQlite too.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
There certainly always more than one approach but I didn't think about different ones.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
The hint were really good to solve the challenging ones.
How were these changes tested?
I tested them in SQLite db and checked the outputs by displaying the results.
A reference to a related issue in your repository (if applicable)
Checklist