Open
Conversation
Updated after reverting the merge
Owner
Author
|
A new pull request. Hopefully this time it is in the right place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated after reverting the merge
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Reverting my previous commit after I merged it before feedback.
I added scripts as requested in the assignment.
I also created a logical model.
What did you learn from the changes you have made?
I learned how to query specific information from a db.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I think creating logical models based on the visual review is not the best approach. We can use automated tools to do that and also we need to review documentations about the business rules since they may change our understanding of the entity relationships.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Working with Git is still not very clear to me. For assignment 1 we were directed. to use VS Code and for assignment 2 directly in Git. This was the main reason that I merged my assignment at a wrong time and before feedback. When I did it in assignment 1 through the VS code I didn't see any merge button and naturally I didn't push it.
How were these changes tested?
I tested my scripts in SQLite and all generated results with no error.
A reference to a related issue in your repository (if applicable)
Checklist