Skip to content

Update assignment1.sql#3

Open
nadeli11 wants to merge 1 commit intomainfrom
assignment-one
Open

Update assignment1.sql#3
nadeli11 wants to merge 1 commit intomainfrom
assignment-one

Conversation

@nadeli11
Copy link
Owner

@nadeli11 nadeli11 commented Apr 21, 2025

Updated after reverting the merge

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Reverting my previous commit after I merged it before feedback.

I added scripts as requested in the assignment.

I also created a logical model.

What did you learn from the changes you have made?

I learned how to query specific information from a db.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I think creating logical models based on the visual review is not the best approach. We can use automated tools to do that and also we need to review documentations about the business rules since they may change our understanding of the entity relationships.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Working with Git is still not very clear to me. For assignment 1 we were directed. to use VS Code and for assignment 2 directly in Git. This was the main reason that I merged my assignment at a wrong time and before feedback. When I did it in assignment 1 through the VS code I didn't see any merge button and naturally I didn't push it.

How were these changes tested?

I tested my scripts in SQLite and all generated results with no error.

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Updated after reverting the merge
@nadeli11
Copy link
Owner Author

A new pull request. Hopefully this time it is in the right place.

Copy link

@JzfL JzfL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 30/30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants