Make creating gridfs chunks customizable #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2011 12:44
Overriding this method allows creating custom chunks, for example with some extra attributes Signed-off-by: Tuomas Huhtanen <github@saynomoo.com>
…ass can be overriden Signed-off-by: Tuomas Huhtanen <github@saynomoo.com>
Author
|
Hi breinero, The whole pull request #53 should be applied to be useful. At least in my use case. |
|
Any progress here? Without this feature it is impossible to do tag aware sharding on chunks collection (which is the most likely target for sharding if you ask from me): http://www.mongodb.org/display/DOCS/Tag+Aware+Sharding |
Collaborator
|
http://jira.mongodb.org/browse/JAVA-475 was closed in 2.8.0, and it looks like these changes were incorporated into the release (see the commit log on the issue). I'm not sure why this pull request was not simply merged, but instead re-applied by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make gridfs files removal efficiently, the chunks need some additional metada which can be indexed. To make it possible to create custom chunks, a new method is introduced: createChunk. This method can then be overriden based on the custom needs. The constructors are also changed to protected so that the class itself can be overriden.
Signed-off-by: Tuomas Huhtanen github@saynomoo.com