MONGOCRYPT-812 add crypt_shared version in errors#1130
Merged
kevinAlbs merged 3 commits intomongodb:masterfrom Feb 18, 2026
Merged
MONGOCRYPT-812 add crypt_shared version in errors#1130kevinAlbs merged 3 commits intomongodb:masterfrom
crypt_shared version in errors#1130kevinAlbs merged 3 commits intomongodb:masterfrom
Conversation
addaleax
approved these changes
Feb 18, 2026
vector-of-bool
approved these changes
Feb 18, 2026
Contributor
vector-of-bool
left a comment
vector-of-bool
left a comment
There was a problem hiding this comment.
LGTM with one comment
test/test-mongocrypt-csfle-lib.c
Outdated
Contributor
There was a problem hiding this comment.
Is this macro definition used for anything?
Contributor
Author
There was a problem hiding this comment.
Ah good spot. That was copy-pasta. Removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves MONGOCRYPT-812
Include the library version in errors from crypt_shared. Changes an error from:
To:
Intended help users identify a too-old crypt_shared on errors encrypting newer syntax.
"csfle" was the old name of the shared library, which was renamed to "crypt_shared" in MONGOCRYPT-434.