fix: remove client-side auth check for Docker anonymous mode #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the client-side authentication check that was blocking message submission when ENABLE_AUTH=false. The server-side auth handling in getCurrentUserId() already properly supports anonymous mode, but the client-side useAuthCheck hook was not aware of this setting. Changes: - Remove useAuthCheck hook and AuthModal from chat.tsx - Add Sign Up/Sign In buttons to ErrorModal for auth errors - Server 401 responses now show ErrorModal with login options This fixes the issue where Docker deployments with ENABLE_AUTH=false would incorrectly prompt users to log in. Closes #756 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_AUTH=falseProblem
When running Docker with
ENABLE_AUTH=false, users were incorrectly prompted to log in when trying to send a message. The server-sidegetCurrentUserId()already properly handles anonymous mode, but the client-sideuseAuthCheckhook was checking Supabase session only, unaware of theENABLE_AUTHsetting.Solution
Remove the client-side pre-check and rely on server-side authentication. When the server returns 401, the ErrorModal now shows Sign Up/Sign In buttons instead of just a Close button.
ENABLE_AUTH=false(Docker)ENABLE_AUTH=true+ unauthenticatedTest plan
ENABLE_AUTH=false: Can send messages without login promptENABLE_AUTH=true: Unauthenticated users see ErrorModal with Sign In/Sign Up buttonsCloses #756
🤖 Generated with Claude Code