Skip to content

Conversation

@xiaocai2333
Copy link
Contributor

issue: #46274

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 11, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 36.94268% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.93%. Comparing base (b2c49d0) to head (95c6c11).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/index/task_stats.go 21.97% 70 Missing and 1 partial ⚠️
internal/datanode/compactor/sort_compaction.go 28.94% 26 Missing and 1 partial ⚠️
internal/storage/sort.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #46279   +/-   ##
=======================================
  Coverage   75.92%   75.93%           
=======================================
  Files        1898     1898           
  Lines      296913   297001   +88     
=======================================
+ Hits       225435   225513   +78     
- Misses      63985    63999   +14     
+ Partials     7493     7489    -4     
Components Coverage Δ
Client 78.18% <ø> (ø)
Core 82.75% <ø> (ø)
Go 73.92% <36.94%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datanode/data_node.go 74.53% <ø> (-0.16%) ⬇️
internal/datanode/index_services.go 68.83% <100.00%> (+0.46%) ⬆️
internal/datanode/services.go 54.11% <100.00%> (ø)
internal/storage/sort.go 72.90% <93.33%> (+1.41%) ⬆️
internal/datanode/compactor/sort_compaction.go 58.26% <28.94%> (-0.32%) ⬇️
internal/datanode/index/task_stats.go 51.22% <21.97%> (-1.48%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants