Skip to content

enhance: [2.6]Estimate index task slot using field size instead of segment size #46276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xiaocai2333 wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

enhance: [2.6]Estimate index task slot using field size instead of segment size #46276

xiaocai2333 wants to merge 1 commit into from

Conversation

@xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Dec 11, 2025

issue: #45186
master pr: #46275

@xiaocai2333 xiaocai2333 added this to the 2.6.8 milestone Dec 11, 2025
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 11, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 11, 2025
@xiaocai2333 xiaocai2333 requested review from czs007 and removed request for cydrain and sunby December 11, 2025 03:30
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Dec 11, 2025

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2025

@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Dec 11, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Dec 11, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #46275 not merged

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Estimate index task slot using field size instead of segment size
d53bb45 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the refine_get_field_size-6 branch from 3435618 to d53bb45 Compare December 11, 2025 04:03
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Dec 11, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #46275 not merged

Use /refresh-label to update related check and label manually

@codecov
Copy link

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.06%. Comparing base (bfe6312) to head (d53bb45).
⚠️ Report is 6 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/datacoord/segment_info.go 70.58% 4 Missing and 1 partial ⚠️
internal/datacoord/util.go 20.00% 1 Missing and 3 partials ⚠️

❌ Your patch check has failed because the patch coverage (70.96%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (76.06%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #46276      +/-   ##
==========================================
+ Coverage   73.54%   76.06%   +2.52%     
==========================================
  Files        1362     1883     +521     
  Lines      212572   293572   +81000     
==========================================
+ Hits       156330   223317   +66987     
- Misses      48809    62813   +14004     
- Partials     7433     7442       +9
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 82.76% <ø> (∅)
Go 74.19% <70.96%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/index_inspector.go 77.77% <100.00%> (-6.30%) ⬇️
internal/datacoord/util.go 83.57% <20.00%> (ø)
internal/datacoord/segment_info.go 85.27% <70.58%> (-0.81%) ⬇️

... and 556 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2025

@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Dec 11, 2025

pipeline cancelled

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Dec 11, 2025

/refresh-label

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Dec 11, 2025

/run-cpu-e2e

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Dec 11, 2025

[INFO] PR Label Summary by Refresh-Label

  • Title: enhance: [2.6]Estimate index task slot using field size instead of segment size
  • Target: 2.6
  • Labels: kind/enhancement, size/M, dco-passed, do-not-merge/need-merge-master-first

[FAILED] PR #46275 not merged

Use /refresh-label to update related check and label manually

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Dec 11, 2025

/ci-rerun-e2e-default

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2025

@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Dec 11, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 Awaiting requested review from czs007

Assignees

No one assigned

Labels

ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Milestone

2.6.8

Development

Successfully merging this pull request may close these issues.

2 participants

@xiaocai2333 @sre-ci-robot