Remove # nosec comments from Python SDK templates
#9206
+21
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python SDK templates contain
# noseccomments that generate false-positive security reports and cause confusion. These comments suppress security scanner warnings oneval()calls and XML parsing operations.Changes
Replace
eval()with direct type mapping: Added_basic_types_mapping = {"str": str, "int": int, "bool": bool, "float": float}dictionaries to bothSerializerandDeserializerclasses. Changedeval(data_type)(data)tocls._basic_types_mapping[data_type](data).Remove XML parsing
# nosecmarkers: Removed# nosecfromET.fromstring()calls. Python 3'sxml.etree.ElementTreedoesn't process external entities by default, making these suppressions unnecessary.Before:
After:
All call sites validate
data_type in self.basic_types.values()before invoking these methods, ensuring the dictionary lookups are safe.Original prompt
# nosecin Python SDK to avoid confusion about security #9205✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.