-
Notifications
You must be signed in to change notification settings - Fork 119
ODAA MicroHack: Documentation improvements and diagrams #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add identity/ folder with separate Terraform config for Entra ID users - Avoids Azure AD eventual consistency race conditions - Enables password rotation and MFA reset workflows - Add dev container with PowerShell, OCI CLI, Azure CLI, Terraform - Auto-login as service principal on container start - OCI CLI path translation for Windows-mounted configs - Remove ingress-nginx Helm module (manual deployment preferred) - Simplify Azure Policy to region-only restrictions for Oracle ADB - Add utility scripts: - deploy-two-phase.ps1: Orchestrated identity + infra deployment - rotate-passwords.ps1: Password rotation workflow - reset-user-mfa.ps1: MFA cleanup for new workshop attendees - microhack.status.ps1: DNS zone health check - Update .gitignore to exclude user_credentials.json and members.json
- Add Deploy-PerfTest.ps1 script for automated performance testing - Add perf-test-odaa-simplified.md with streamlined walkthrough - Update cleanup-odaa-and-destroy.ps1 with exclusion options and WhatIf support - Update deploy-base-pods.ps1 with cluster exclusions and auto-stop/start
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all files which are not inside your folder "10_Oracle_on-Azure" from your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in database configuration checks there is a hostname in the connection information. This should be avoided. Instead give instructions how to build the connection string for your personal environment, or provide a script which returns the information dynamically.
Also tenant or resource IDs do not belong into this repo. Please remove them or make them non-readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing tenant id/name information wherever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid Tenant_id and client_id values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably want to replace the pointer to your private fork with the official repo URL for merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host and service endpoints should not be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing tenancy identifers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host name should be made unreadable/not provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existing users should not be identifiable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended to have this zip file in the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some markup meta information appear in the markup preview. Maybe there is something broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing n existing compartment id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing subscription id and endoint information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing storage account name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing UPN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing UPN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing UPN and group ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compartment id should not be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subscription ids should be avoided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing subscription ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing tenant id and client id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing tenant id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing host name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid providing host names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not include files outside your folder 10_Oracle_on_Azure in this PR
skiddder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not provide hostnames, tenant ids or other potentially sensitive data in this repository
Overview
This PR includes updates to the ODAA MicroHack documentation:
Changes
Related