Skip to content

Conversation

@thecristen
Copy link
Collaborator

No ticket, just trying to help our compile-time mess.

The current output of mix xref graph --format cycles --label compile-connected includes 5 distinct cycles.

This PR removes these 3 cycles:

Cycle of length 4 (2 compile):

    lib/dotcom/cldr.ex (compile)
    lib/dotcom/gettext.ex (compile)
    lib/dotcom/gettext/plural.ex
    lib/dotcom/locales.ex

Cycle of length 3 (2 compile):

    lib/dotcom/cache/multilevel.ex (compile)
    lib/dotcom/cache/publisher.ex
    lib/dotcom/cache/subscriber.ex (compile)

Cycle of length 2 (1 compile):

    lib/alerts/alert.ex
    lib/alerts/priority.ex (compile)

@thecristen thecristen requested a review from a team as a code owner January 22, 2026 20:49
@thecristen thecristen requested a review from joshlarson January 22, 2026 20:49
@thecristen thecristen added the dev-green Deploy to dev-green label Jan 22, 2026
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few little nits, but I appreciate getting rid of a bunch of cycles!

Co-authored-by: Josh Larson <jlarson@mbta.com>
@thecristen thecristen merged commit b68cd8d into main Jan 23, 2026
17 checks passed
@thecristen thecristen deleted the cbj/remove-compile-cycles branch January 23, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants