Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Dec 29, 2025

In the next PR, will use marklogic-junit5 to make "real" tests that clear out all data except "test-data" documents.

Copilot AI review requested due to automatic review settings December 29, 2025 22:38
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Copyright Validation Results
Total: 12 | Passed: 1 | Failed: 0 | Skipped: 11 | at: 2025-12-29 22:47:16 UTC | commit: d92930e

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • build.gradle
  • gradle.properties
  • marklogic-client-api-functionaltests/build.gradle
  • marklogic-client-api/build.gradle
  • test-app/build.gradle
  • test-app/src/main/ml-data/optic/test/collections.properties
  • test-app/src/main/ml-data/optic/vectors/collections.properties
  • test-app/src/main/ml-data/optic/zipcodes/collections.properties
  • test-app/src/main/ml-data/sample/collections.properties
  • test-app/src/main/ml-data/sample2/collections.properties

✅ Valid Files

  • marklogic-client-api/src/test/java/com/marklogic/client/test/ssl/SSLTest.java

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates project dependencies and adds marklogic-junit5 to support test data management. The changes prepare the test infrastructure for upcoming improvements where tests will preserve documents in the "test-data" collection.

  • Dependency version bumps for Jackson, OkHttp, JUnit, Logback, and various Apache Commons libraries
  • Addition of marklogic-junit5 dependency with exclusion configuration
  • Tagging of test data files with "test-data" collection across multiple test directories

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle.properties Defines version variables for OkHttp, Jackson, and JUnit dependencies
marklogic-client-api/build.gradle Adds marklogic-junit5 dependency, configures exclusions, and updates test dependencies
marklogic-client-api-functionaltests/build.gradle Updates test dependencies to use centralized version variables
test-app/build.gradle Adds mavenLocal repository and updates logback-classic version
test-app/src/main/ml-data/sample/collections.properties Adds test-data collection to all sample documents
test-app/src/main/ml-data/sample2/collections.properties Adds test-data collection to sample2 documents
test-app/src/main/ml-data/optic/test/collections.properties Adds test-data collection to optic test documents
test-app/src/main/ml-data/optic/vectors/collections.properties Creates new file with test-data collection assignment
test-app/src/main/ml-data/optic/zipcodes/collections.properties Adds test-data collection to zipcode documents

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

second.txt=document-format-query-test
*=test-data
suggestion.xml=http://some.org/suggestions,test-data
first.xml=http://some.org/collection1,http://some.org/collection,test-data
Copy link

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 'http://some.org/collection2' to 'http://some.org/collection' on line 3, but this appears to be removing '2' from collection2. If this is intentional, consider whether this change affects expected collection membership.

Suggested change
first.xml=http://some.org/collection1,http://some.org/collection,test-data
first.xml=http://some.org/collection1,http://some.org/collection2,test-data

Copilot uses AI. Check for mistakes.
In the next PR, will use marklogic-junit5 to make "real" tests that clear out all data except "test-data" documents.
@rjrudin rjrudin merged commit dcb8064 into develop Dec 29, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/bumps branch December 29, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants