-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-26420 Bumping dependencies and adding marklogic-junit5 #1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates project dependencies and adds marklogic-junit5 to support test data management. The changes prepare the test infrastructure for upcoming improvements where tests will preserve documents in the "test-data" collection.
- Dependency version bumps for Jackson, OkHttp, JUnit, Logback, and various Apache Commons libraries
- Addition of
marklogic-junit5dependency with exclusion configuration - Tagging of test data files with "test-data" collection across multiple test directories
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Defines version variables for OkHttp, Jackson, and JUnit dependencies |
| marklogic-client-api/build.gradle | Adds marklogic-junit5 dependency, configures exclusions, and updates test dependencies |
| marklogic-client-api-functionaltests/build.gradle | Updates test dependencies to use centralized version variables |
| test-app/build.gradle | Adds mavenLocal repository and updates logback-classic version |
| test-app/src/main/ml-data/sample/collections.properties | Adds test-data collection to all sample documents |
| test-app/src/main/ml-data/sample2/collections.properties | Adds test-data collection to sample2 documents |
| test-app/src/main/ml-data/optic/test/collections.properties | Adds test-data collection to optic test documents |
| test-app/src/main/ml-data/optic/vectors/collections.properties | Creates new file with test-data collection assignment |
| test-app/src/main/ml-data/optic/zipcodes/collections.properties | Adds test-data collection to zipcode documents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| second.txt=document-format-query-test | ||
| *=test-data | ||
| suggestion.xml=http://some.org/suggestions,test-data | ||
| first.xml=http://some.org/collection1,http://some.org/collection,test-data |
Copilot
AI
Dec 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected 'http://some.org/collection2' to 'http://some.org/collection' on line 3, but this appears to be removing '2' from collection2. If this is intentional, consider whether this change affects expected collection membership.
| first.xml=http://some.org/collection1,http://some.org/collection,test-data | |
| first.xml=http://some.org/collection1,http://some.org/collection2,test-data |
f7bf2ff to
328e52e
Compare
In the next PR, will use marklogic-junit5 to make "real" tests that clear out all data except "test-data" documents.
328e52e to
d92930e
Compare
In the next PR, will use marklogic-junit5 to make "real" tests that clear out all data except "test-data" documents.