Open
Conversation
dwz92
suggested changes
Sep 10, 2024
dwz92
left a comment
There was a problem hiding this comment.
Part 1: please return a bool value instead of a string value
Part 2: Your function does not pass the case where anagram_checker("Silent", "Listen", True) #False. Please fix your function so that is_case_sensitive is accounted for.
Owner
Author
|
Hi Emma,
I made the changes. Could you please let me know if I should submit it
again or merge it?
…On Tue, Sep 10, 2024 at 7:28 PM Emma ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Part 1: please return a bool value instead of a string value
Part 2: Your function does not pass the case where anagram_checker("Silent",
"Listen", True) #False. Please fix your function so that is_case_sensitive
is accounted for.
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKSZRPZMQMX6YCDKW2QML2LZV56BPAVCNFSM6AAAAABNM4TQTOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJUGI3TANRVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Marjan Rajabi*
PhD in Statistics
Statistical Researcher & Data Scientist
Phone: (437) 473-2820
|
|
I do not see any change to your code. |
Owner
Author
|
Hi Emma:
I changed my assignment_1 on my computer. Please guide me on how I can
change it on my repository.
Thanks a lot
…On Wed, Sep 11, 2024 at 12:52 AM Emma ***@***.***> wrote:
I do not see any change to your code.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKSZRPZTS3AVEBLHJNVH54LZV7EA5AVCNFSM6AAAAABNM4TQTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBSGYYTQMRTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Marjan Rajabi*
PhD in Statistics
Statistical Researcher & Data Scientist
Phone: (437) 473-2820
|
|
the standard procedure you do when you push to GitHub. git add, commit, and then push. Remember to do it from your assignment branch. |
Owner
Author
|
Thanks for the tip!
Also, could you see my assignment_2?
https://github.com/marjanrajabi437/python/blob/main/02_activities/assignments/assignment_2.ipynb
…On Wed, Sep 11, 2024 at 3:18 PM Emma ***@***.***> wrote:
the standard procedure you do when you push to GitHub.
git add, commit, and then push. Remember to do it from your assignment
branch.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKSZRP5X3FBOXSB4IA4GKGDZWCJQPAVCNFSM6AAAAABNM4TQTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGUZDCMBSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Marjan Rajabi*
PhD in Statistics
Statistical Researcher & Data Scientist
Phone: (437) 473-2820
|
|
Unfortunately I am not the marking TA for assignment 2, sidra and pedram are assigned the marking for that one. |
dwz92
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I changed it to make it easier to read and do it faster.
What did you learn from the changes you have made?
I have several choices to write code, but which one is simplest to read and explain?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Thinking about using it for and while to write code.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, I had some challenges with the TRUE and FALSE code. I use function and put command on return command.
How were these changes tested?
By running it several times and change to get a response without errors.
A reference to a related issue in your repository (if applicable)
I searched it on Google and checked the sites also on chatgtp but it didn't work well.
Checklist