Skip to content

first commit#1

Open
marjanrajabi437 wants to merge 2 commits intomainfrom
assignment-1
Open

first commit#1
marjanrajabi437 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@marjanrajabi437
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I changed it to make it easier to read and do it faster.

What did you learn from the changes you have made?

I have several choices to write code, but which one is simplest to read and explain?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Thinking about using it for and while to write code.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes, I had some challenges with the TRUE and FALSE code. I use function and put command on return command.

How were these changes tested?

By running it several times and change to get a response without errors.

A reference to a related issue in your repository (if applicable)

I searched it on Google and checked the sites also on chatgtp but it didn't work well.

Checklist

  • I can confirm that my changes are working as intended

Copy link

@dwz92 dwz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1: please return a bool value instead of a string value

Part 2: Your function does not pass the case where anagram_checker("Silent", "Listen", True) #False. Please fix your function so that is_case_sensitive is accounted for.

@marjanrajabi437
Copy link
Owner Author

marjanrajabi437 commented Sep 11, 2024 via email

@dwz92
Copy link

dwz92 commented Sep 11, 2024

I do not see any change to your code.

@marjanrajabi437
Copy link
Owner Author

marjanrajabi437 commented Sep 11, 2024 via email

@dwz92
Copy link

dwz92 commented Sep 11, 2024

the standard procedure you do when you push to GitHub.

git add, commit, and then push. Remember to do it from your assignment branch.

@marjanrajabi437
Copy link
Owner Author

marjanrajabi437 commented Sep 11, 2024 via email

@dwz92
Copy link

dwz92 commented Sep 11, 2024

Unfortunately I am not the marking TA for assignment 2, sidra and pedram are assigned the marking for that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants