fix: focus on editors and buttons after layout shift from hidden code #7489
+519
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
Light2Dark
reviewed
Dec 15, 2025
| * First tries to scroll the active line into view, if the cell is focused. | ||
| * If not, it scrolls the cell container into view. | ||
| */ | ||
| export function scrollCellIntoView(cellId: CellId): void { |
Contributor
There was a problem hiding this comment.
There's a file called scrollCellIntoView.ts. Should this live there and/or renamed?
| const restoreFocus = useRestoreFocus(); | ||
|
|
||
| useEffect(() => { | ||
| if (open) { |
Contributor
There was a problem hiding this comment.
any thoughts on this lint comment? I think we could make a handleOpen function and call this wherener setOpen()
Contributor
There was a problem hiding this comment.
oh, the lint comment is Avoid using state and effects as an event handler. Instead, call the event handling code directly when the event occurs
Contributor
Author
There was a problem hiding this comment.
yea i can make a handleOpen callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7487
It may not (or ever) feel perfect; layout shifts will be inevitable. But this does return the focus to the selected line or button or editor after closing a temporarily shown cell (temporarily shown --> marked hidden, but was focused)