Open
Conversation
dwz92
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added my own code to complete the functions
What did you learn from the changes you have made?
How to use file reading methods
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
using readlines instead of the readline method
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Just issues with making sure the functions were working as desired
How were these changes tested?
Went through a couple of versions
A reference to a related issue in your repository (if applicable)
Had to download a new version
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
Checklist