Skip to content

Sourcery refactored master branch#1

Open
sourcery-ai[bot] wants to merge 1 commit intomasterfrom
sourcery/master
Open

Sourcery refactored master branch#1
sourcery-ai[bot] wants to merge 1 commit intomasterfrom
sourcery/master

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Aug 4, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

opStk.append('#')
else:
while (len(opStk) > 0):
while opStk:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function calc refactored with the following changes:

  • Simplify sequence comparison (simplify-len-comparison)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Aug 4, 2020

Sourcery Code Quality Report (beta)

✅  Merging this PR will increase code quality in the affected files by 0.01 out of 10.

Quality metrics Before After Change
Complexity 11.50 11.50 0.00
Method Length 75.24 73.25 -1.99 🔵
Quality 7.81 7.82 0.01 🔵
Other metrics Before After Change
Lines 110 110 0
Changed files Quality Before Quality After Quality Change
pycalc/calc.py 7.81 7.82 0.01 🔵

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation
pycalc/calc.py calc 56 311.78 1.39 Split out functionality. Reduce complexity

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants