systemd: Fix shared mounts (again)#26
Open
AlexanderS wants to merge 3 commits intolinux-vserver:masterfrom
Open
systemd: Fix shared mounts (again)#26AlexanderS wants to merge 3 commits intolinux-vserver:masterfrom
AlexanderS wants to merge 3 commits intolinux-vserver:masterfrom
Conversation
We want to propagate mounts from the parent namespaces into the vserver (something like vmount or mount within vnamespace), but we do not want to propagate the changes from the vserver back to the parent namespace.
This reverts commit 9877e4b. After we fixed the cleanupMount using the correct shared subtree semantic, we can start using it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried to fix the systemd stuff with the shared mounts in 2698c20 and 7c2397d, broke vmount (mount from the admin namespace), reverted the commit in 56d2df4 and broke support with systemd on the host.
After reading the documentation about shared subtrees I am pretty sure, that we do not want to have private mounts but slave mounts. That way the mounts from parent namespaces could propagate into the vserver, but the changes made while starting the container does not propagate up to the host.