Open
Conversation
* Fix lintian warnings:
* manpage-has-errors-from-man
* manpage-has-bad-whatis-entry
* Fix spelling error:
* I: util-vserver: spelling-error-in-manpage
-> informations information
* This adds two new utilities: viotop and vhtop following the vtop model. * With viotop and vhtop you can execute iotop and htop utilities and show the stats for all the processes on the system, instead of only the ones in the current s_context.
* possible bashism ($"foo" should be eval_gettext "foo"). * but gettext.sh is not sourced, neither translations are available, so just replaced 'echo $"foo"' with 'echo "foo"'.
Member
|
Aside from the "bashisms" commit, this looks pretty mergeable. Any chance you could get rid of that? util-vserver is explicitly a bash-only project. |
Author
|
Then, why the headers of the files are #!/bin/sh instead of #!/bin/bash ???? If you want to target bash scripting, you should fix the shebang. |
Contributor
|
@dhozac imho you can merge this and just reseting last commit out (last commit is what you don't like) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes the fixes that I made until today to util-vserver while working on the Debian package available at git://git.debian.org/git/pkg-vserver/pkg-vserver.git