Skip to content

updated marks into mark to avoid any confusion #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShlokMohanty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated marks into mark to avoid any confusion #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/main/java/com/b/simple/design/business/student/StudentHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ public class StudentHelper {
/*
* You get a grade B if marks are between 51 and 80 (both inclusive). Except for Maths where the upper limit is increased by 10.
*/
public boolean isGradeB(int marks, boolean isMaths) {
return isMaths ? marks>=51 && marks<=90 : marks>=51 && marks<=80;
public boolean isGradeB(int mark, boolean isMaths) {
return isMaths ? mark>=51 && mark<=90 : mark>=51 && mark<=80;
}

/* PROBLEM 2 */
Expand All @@ -21,7 +21,7 @@ public String getGrade(int mark, boolean isMaths) {

if (isGradeA(mark, isMaths))
grade = "A";
else if (isBGrade(mark, isMaths)) {
else if (isGradeB(mark, isMaths)) {
grade = "B";
}
return grade;
Expand Down Expand Up @@ -55,12 +55,12 @@ private boolean isBGrade(int mark, boolean isMaths) {
* marks2 - your friends marks
*/

public String willQualifyForQuiz(int marks1, int marks2, boolean isMaths) {
if ((isMaths ? marks1 <= 25 : marks1 <= 20)
|| (isMaths ? marks2 <= 25 : marks2 <= 20)) return "NO";
if ((isMaths ? marks1 >= 85 : marks1 >= 80)
|| (isMaths ? marks2 >= 85 : marks2 >= 80)) return "YES";
public String willQualifyForQuiz(int mark1, int mark2, boolean isMaths) {
if ((isMaths ? marks <= 25 : mark1 <= 20)
|| (isMaths ? mark2 <= 25 : mark2 <= 20)) return "NO";
if ((isMaths ? mark1 >= 85 : mark1 >= 80)
|| (isMaths ? mark2 >= 85 : mark2 >= 80)) return "YES";
return "MAYBE";
}

}
}