Skip to content

Fixes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kezhuw wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #5

kezhuw wants to merge 3 commits into from

Conversation

@kezhuw
Copy link

@kezhuw kezhuw commented Jan 4, 2014

See commit messages.

other issues:

  • make_daemon() close stdin/stdout/stderr, it is erroneous. dup2 "/dev/null" is a choice, or better to to files.
  • socket_accept() don't handle case that there is no connection, which may happen in rare case, in listen queue (qnet_tcp_accept() return 0(QOK) in this case, in my opinion, it is not a good idea, just because 0 is a valid file descriptor).

kezhuw added 3 commits January 4, 2014 22:00
@kezhuw
bugfix about socket connecting in qapi_net.c:
69a4fd1 
  * qsocket_t's event.data is socket itself, not actor
  * uninitialized 'remote' address in socket_connect()
  * redundant socket entity created in socket_connect(),
    already in qltcp_connect()
  * error retrieved from getsockopt is a meaningful errno
@kezhuw
field 'ldb' in qworker_t defined only in -DDEBUG
b8f6f56
@kezhuw
always use $(MAKE) instead of make in Makefile
492058e 
work in case that gmake is not the default make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kezhuw