-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Mobile: Fixes #13869: Fix some icons are invisible: Upgrade react-native-vector-icons to v12
#13905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
personalizedrefrigerator
wants to merge
12
commits into
laurent22:dev
Choose a base branch
from
personalizedrefrigerator:pr/mobile/upgrade-rn-vector-icons
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing done: 1. Start the Android application in development mode. 2. Open the Markdown editor. 3. Verify that all default toolbar buttons have icons. - Missing icons would be shown as question marks. 4. Verify that all possible toolbar buttons have icons. - Open the toolbar configuration dialog and check manually. 5. Repeat steps 3-4 for the Rich Text Editor. 6. Open a plugin dialog. Verify that the close button is visible. 7. Open the search panel. Verify that the clear button is visible. 8. Open settings. Verify that the settings tab icons are visible.
1. Open the Rich Text Editor. Verify that all buttons in the toolbar have icons. - Note: In my browser (Chrome), some icons appear bolder than on Android. This seems to also be the case on app.joplincloud.com, so is not a regression. 2. Open the Rich Text Editor's "Manage toolbar options". Verify that all icons are present. 3. Repeat steps 1-2 for the Markdown editor. 4. Verify that all settings tabs have icons. 5. Open the beta dialog. Verify that the close button has an icon.
Testing (iOS 18.4 simulator): 1. Open the Markdown editor. Verify that all buttons in the Markdown toolbar have icons. 2. Verify that all items in the "choose what to display" menu have icons. 3. Repeat steps 1-2 for the Rich Text Editor. 4. Open the note screen, then the sidebar. Verify that sidebar items have icons. 5. Open settings, verify that all settings items have icons.
react-native-vector-icons to v12react-native-vector-icons to v12
react-native-vector-icons to v12react-native-vector-icons to v12
Owner
|
Looks like there may be some issue with the types? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
react-native-vector-iconsto v12.Fixes #13869.
Notes
react-native-vector-iconshas been split into multiple packages in the@react-native-vector-icons/NPM organization.ant indent-leftandant indent-righticons seem to no longer exist. These icons have been replaced withmaterial format-indent-decreaseandmaterial format-indent-increase, respectively.Testing
Android 16 emulator (release mode APK):
Note
The below testing was done prior to removing the unused fontisto icon font.
Testing (iOS 18.4 simulator, dev mode):
Android 10 emulator, dev mode:
Web (Chrome):