Skip to content

Conversation

@kfigiela
Copy link

@kfigiela kfigiela commented Dec 1, 2013

(Almost) copy-paste merge from 3.8 branch.

@koalo
Copy link
Owner

koalo commented Dec 1, 2013

Thank you!
Have you tested it?

@kfigiela
Copy link
Author

kfigiela commented Dec 1, 2013

Yes, it is working fine :)

The only issue is that I get some DMA warnings in dmesg, but playback still works:

[ 4364.432611] bcm2708-dmaengine bcm2708-dmaengine: DMA transfer could not be terminated

@kfigiela
Copy link
Author

kfigiela commented Dec 1, 2013

I'm not sure why github shows here my another commit, but this one (d16f542) shouldn't be merged.

@koalo
Copy link
Owner

koalo commented Dec 2, 2013

Github adds commits to the pull request as long as you push them to the same branch and the pull request is not merged, yet. The DMA error seems like a bug in my DMA driver - I will have a look at it.

@koalo
Copy link
Owner

koalo commented Dec 2, 2013

Could you please try to increase the timeout in this line:
https://github.com/koalo/linux/blob/rpi-3.10.y/drivers/dma/bcm2708-dmaengine.c#L380

E.g. to 10000

@kfigiela
Copy link
Author

kfigiela commented Dec 2, 2013

I've increased timeout to 10 000 and no warnings so far. I will give you more feedback on that tomorrow evening.

@kfigiela
Copy link
Author

kfigiela commented Dec 3, 2013

Ok, no warnings after whole day. Increasing the timeout fixed the issue.

@koalo
Copy link
Owner

koalo commented Dec 4, 2013

Thank you very much for reporting and testing!

@koalo koalo closed this Dec 27, 2013
@koalo
Copy link
Owner

koalo commented Dec 27, 2013

Regarding the original request: I haven't merged this, because I was about to submit the driver to raspberrypi/linux. Please rebase it and submit the pull request there.

@kfigiela
Copy link
Author

Ok, will do it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants