-
Notifications
You must be signed in to change notification settings - Fork 0
New branch "assignment-2" and final answers #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ❌ | No server log files in data/raw |
| Part 1 - Q6 | ❌ | No user log files in data/raw; No event log files in data/raw |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ❌ | ls command run on wrong directory |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status | comment |
|---|---|---|
| Part 1 - Q1 | ✅ | |
| Part 1 - Q2 | ✅ | |
| Part 1 - Q3 | ✅ | |
| Part 1 - Q4 | ✅ | |
| Part 1 - Q5 | ✅ | |
| Part 1 - Q6 | ✅ | |
| Part 1 - Q7 | ✅ | |
| Part 1 - Q8 | ✅ | |
| Part 2 | ❌ | coworker-changes branch not found in commit history |
Please address the issues listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autograder results
| question | status |
|---|---|
| Part 1 - Q1 | ✅ |
| Part 1 - Q2 | ✅ |
| Part 1 - Q3 | ✅ |
| Part 1 - Q4 | ✅ |
| Part 1 - Q5 | ✅ |
| Part 1 - Q6 | ✅ |
| Part 1 - Q7 | ✅ |
| Part 1 - Q8 | ✅ |
| Part 2 | ✅ |
xindizhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, amazing work — the assignment is complete, and no further changes are needed!
Just a quick reminder for future submissions — including a brief PR description is good practice, as it helps your "project-mates" quickly understand what’s going on.
|
@xindizhang thanks for you feedback. Am I supposed to see any changes here after your revision? as I still see the "merge pull request" bottom green, assuming it is not merged yet. right? |
|
Great question! To clarify — I can only leave comments, request changes, or approve a pull request. I don’t have access to make changes directly. Once I’ve approved it, you’re free to go ahead and merge the pull request yourself. Let me know if you have any questions! |
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist