fix Buffer not defined when running in some browser environments#81
Closed
rbuels wants to merge 2 commits intokeichi:masterfrom
Closed
fix Buffer not defined when running in some browser environments#81rbuels wants to merge 2 commits intokeichi:masterfrom
rbuels wants to merge 2 commits intokeichi:masterfrom
Conversation
Contributor
|
just for reference this fork https://github.com/gmod/binary-parser includes this fix and also one for running in webworker (assigns to self.Buffer) |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a small webpack-based test runner to run the mocha tests in whatever the default browser is. Run
npm run test-webpackto run it.I think this probably fixes #60