Fix badge generation and enhance debugging tools (#6) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert browser names to lowercase for consistent matching - replace null return with exception for unsupported browsers refactor(tests): reorganize test package structure - rename packages to include junit for clarity - relocate and rename test classes for Selenium and Playwright feat(tests): add new Selenium browser test classes - introduce SeleniumChromeTest and SeleniumFirefoxTest classes - implement browser name retrieval in new test classes chore(tests): remove outdated Selenium test classes - delete ChromeTest and FirefoxTest classes from selenium package
- introduce testng and junit profiles to separate testing strategies - update maven-failsafe-plugin version for improved compatibility test(testng): implement LoginTest for TestNG framework - add setup and teardown methods for browser initialization and cleanup - include tests for login failure scenarios with screenshots feat(utils): add utility for taking screenshots - implement takeScreenshot method in Utils class for capturing test results feat(testng): add TestNG suite configuration - create testng-login.xml for parallel test execution with Chrome and Firefox
build(pom.xml): enhance dependency management and profiles - add `dependencyManagement` section for better dependency control - update dependencies and versions for consistency - modify profiles for comprehensive test coverage style(logging): improve logging messages in tests - add specific logging for Selenium and TestNG initialization chore(testng): move and update TestNG suite file - rename and relocate `testng-login.xml` for better organization - change parallel execution to `tests` for efficient test runs
- upgrade TestNG version from 7.8.0 to 7.11.0 - add configuration for maven-surefire-plugin to include/exclude specific tests - configure maven-failsafe-plugin with execution goals for integration testing (testng tests)
- change report path from surefire to failsafe for consistency - update job names for clarity in GitHub Pages deployment
- adjust the path for maven test reports to reflect the correct directory structure
- change artifact path to target/failsafe-reports for consistency - comment out combining reports step to streamline workflow - update publish directory to target/failsafe-reports for GitHub Pages deployment
- added extra blank line in GitHub Actions workflow file for workflow testing porpuses
- eliminate unnecessary blank line to improve readability
- change test badge URL to reflect updated JSON file location - ensure link points to correct selenium tests page
- correct repository path in Java CI badge URL for accurate display
- change repository name in badge URLs from lowercase to title case - ensure consistency with the updated repository naming convention
- introduce successMessage locator in LoginPage - add methods to retrieve success message text test(login): enhance test coverage with data provider - implement data-driven tests for login scenarios - add credentials data provider for parameterized testing docs(credentials): add credentials data file - create credentials.tsv file for test data storage - include various login scenarios and expected outcomes refactor(utils): add utility for reading data files - implement readDataFile method to parse credentials file - support both CSV and TSV formats for flexibility
- install Allure CLI in GitHub Actions workflow - generate and upload Allure report for test results build(pom): integrate Allure and AspectJ dependencies - add Allure and AspectJ dependencies to pom.xml - configure Maven profiles and plugins for Allure reporting feat(test): enhance LoginTest with Allure annotations - add Epic and Feature annotations for Allure reporting - implement ITest interface for custom test name in LoginTest i18n(test): add Spanish annotations in LoginTest - include Spanish descriptions and annotations in LoginTest chore(test): update TestNG configuration for Allure listener - add Allure listener to testng-login.xml configuration file
- remove manual Allure CLI installation - add Allure report action for report building - update paths for allure-history usage
- fix typo in directory path from "history" to "allure-history" in testrun.yml
- add steps to list contents of current, target, and build directories - assist in diagnosing potential issues in the build process
- remove unnecessary build directory listing - adjust allure_results path for consistency
- add testng profile to maven test command for specific test execution - create allure directory in combined target for organized test reports
- change report paths to use a unified 'reports/' directory for consistency - adjust paths in 'Combine Failsafe TestNG reports' step accordingly
- remove directory listing for target directory - add directory listing for reports directory to ensure accurate file inspection
- add listing of target directory contents for better visibility - correct copy path for failsafe reports to fix workflow execution
- rename artifact names for clarity (maven-testng-report, maven-allure-report) - separate upload steps for TestNG and Allure reports - update download paths for better directory structure
- add step to list directory contents for debugging - update report paths and names for clarity and accuracy
- rename build step to "Build allure test report" for clarity - update report path from "failsafe-reports" to "testng-reports" - adjust combine step to reflect new report paths and names
- add trailing slashes to source directories in copy command to fix path issues
- fix incorrect directory copy paths for allure-history and testng-reports - ensure all files are correctly copied to target directories
- change allure_results directory to target/allure-results for consistency with project structure
- add register button locator - implement clickRegister method for button interaction - introduce register method for registration process
- fix typo in @feature annotation from "crecenciales" to "credenciales" - correct typo in testName format string from "Logn" to "Login"
- create `RegisterPage.java` for handling registration actions - implement `RegisterTest.java` for testing registration scenarios - add `registerTest.csv` for test data input - update `testng-login.xml` to include registration parameters - create `testng-register.xml` for running registration tests
- include testng-register.xml to test suite for comprehensive testing - ensure registration tests are executed with login tests
- ignore allure-report directory to prevent it from being tracked by git
- create test for login failure with invalid credentials - create test for successful login - create tests for registration failure with invalid email formats - create tests for registration with already registered email - create tests for registration with empty fields
- change WebDriver to ThreadLocal for thread safety - update driver access method to use ThreadLocal - ensure WebDriver is properly removed after tests 🐛 fix(test): clear created users list after cleanup - add condition to check and clear the created users list after cleanup
- modify test to use unique email format by appending browser name - update created users list with modified email for tracking
- modify testRegister to append browser info to email for unique identification - update createdUsers list to store unique email after successful registration
* bug: added find/grep/awk for debugging * fix: wrong tests number informed to badge generator * fix: wrong tests number informed to badge generator * fix: wrong tests number informed to badge generator * fix: wrong tests number informed to badge generator * fix: wrong tests number informed to badge generator * code review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: added find/grep/awk for debugging
fix: wrong tests number informed to badge generator