Open
Conversation
6844a0b to
3f658bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a second elixir implementation and I thought about submitting it. It is incrementally better than the existing solution IMO but not by a lot. I'll leave you to judge whether this is merge worthy or not (at least I had fun!).
Differences:
Cons:
I'm not sure if the single commit format is good or not, I'm looking for feedback on that.
Anyway, thanks for the challenge, it was not my first approach with lisp, but if it were it would have been much more fun :)
Pull request requirements:
the implementation name.
Additional requirements if you are adding a new implementation (see FAQ for details):
impls/<IMPL>/Dockerfileimpls/<IMPL>/MakefileIMPLS.ymlMakefile.implsREADME.md