added functionality in assignment.sh project setup script to organize… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… log files
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added functionality to the project setup Bash script to organize log files into server, user, and event directories. Scrubbed personal data identifying IP addresses and logged remaining file names in an inventory file.
What did you learn from the changes you have made?
Good introduction/refresher of Git processes.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Creation of the inventory.txt file could have been done with "ls -R ./data/processed > inventory.txt", which would have distinguished which files were in which subdirectory. From the wording of the assignment, I decided this was undesirable.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No challenges.
How were these changes tested?
It was noticed that each of the log types had 50 files, excluding the IP address user files. Some lines were tested in the terminal before running through the script. The final output was checked for the completed script.
Directories were visually checked that files were included iff they were named appropriately. To confirm the number of files, the command
" ls newproject/data/processed/<log_type>_logs/ -1 | wc -l"
was run for each directory to list the files, one per line, and count the number of lines.
A reference to a related issue in your repository (if applicable)
Checklist