Remove globalObject #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

domenic merged 1 commit into jsdom:main from asamuzaK:prop

Jan 11, 2026

Contributor

asamuzaK commented Jan 10, 2026

Part of #280

Removed unnecessary argument passing (globalObject)
Changed export style to Define & Export


          Remove globalObject

6db1d81

domenic approved these changes

View reviewed changes

Member

domenic left a comment

I like how this allows us to remove several opt arguments entirely.

domenic merged commit 38ab569 into jsdom:main

3 checks passed

asamuzaK deleted the prop branch

January 11, 2026 09:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet