fix: support custom macOS packages in file dialogs #1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where custom macOS package types (like .rtfd) were not properly recognized in file dialogs when filtering by extension. The fix modifies the UTType creation logic to first attempt creating UTTypes with package conformance before falling back to the regular method.
- Adds a two-stage UTType creation approach: first try with package conformance, then fallback to regular creation
- Ensures custom package extensions like .rtfd are properly recognized in file dialogs
- Maintains backward compatibility with non-package file types
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| UTType* packageType = [UTType typeWithIdentifier:@"com.apple.package"]; | ||
| UTType* utt = [UTType typeWithFilenameExtension:@(ext.c_str()) | ||
| conformingToType:packageType]; |
There was a problem hiding this comment.
The packageType UTType is being created for every file extension in the loop. Consider moving this outside the loop to avoid redundant object creation.
| // necessary for custom macOS packages like .rtfd to be recognized | ||
| // properly in file dialogs. If that fails, fall back to the regular | ||
| // method. | ||
| UTType* packageType = [UTType typeWithIdentifier:@"com.apple.package"]; |
There was a problem hiding this comment.
The hardcoded string 'com.apple.package' should be defined as a constant to improve maintainability and reduce the risk of typos.
* fix: accentColor set distinguishes the frame * chore: invalid change * fix: lint
Fixes an issue where custom macOS package types (like .rtfd) were not properly recognized in file dialogs when filtering by extension. The problem occurred because UTType creation didn't specify the package conformance, causing the system to not recognize these files as valid packages. The fix attempts to create UTTypes with com.apple.package conformance first, then falls back to the regular method if that fails. This ensures that package extensions like .rtfd are properly recognized while maintaining compatibility with non-package file types. Fixes electron#48191 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jjeff
force-pushed
the
fix/48191-mac-package-files
branch
from
96e18ae to
2bd0c7d
Compare
Fixes an issue where custom macOS package types (like .rtfd) were not properly recognized in file dialogs when filtering by extension. The problem occurred because UTType creation didn't specify the package conformance, causing the system to not recognize these files as valid packages.
The fix attempts to create UTTypes with com.apple.package conformance first, then falls back to the regular method if that fails. This ensures that package extensions like .rtfd are properly recognized while maintaining compatibility with non-package file types.
Fixes electron#48191
🤖 Generated with Claude Code
Description of Change
Checklist
npm testpassesRelease Notes
Notes: