Skip to content

Comments

update GitHub Pages domain suffix to github.io#128

Closed
inntran wants to merge 1 commit intojekyll:masterfrom
inntran:master
Closed

update GitHub Pages domain suffix to github.io#128
inntran wants to merge 1 commit intojekyll:masterfrom
inntran:master

Conversation

@inntran
Copy link

@inntran inntran commented Jun 3, 2018

Since GitHub has moved from .com to .io to host gh-pages, https://blog.github.com/2013-04-05-new-github-pages-domain-github-io/
It makes sense to update here as well.

@inntran
Copy link
Author

inntran commented Jun 3, 2018

I checked the failed test, run script/cibuild locally on macOS 10.13, with Ruby 2.5.1, no errors.

@parkr
Copy link
Member

parkr commented Jun 4, 2018

This is a legacy fallback! Check the value of that array. It's all possible domains. For non-Enterprise users, that includes username.github.com. The implementation for default_user_domain will be username.github.io, but we fall check username.github.com too so we don't break compatibility.

@parkr parkr closed this Jun 4, 2018
@inntran
Copy link
Author

inntran commented Jun 4, 2018

I understand. The reason I thought it was an issue: on local setup, it's recognized as a project_page, but on GitHub.com it's correctly recognized as a user_page, showing different links(project vs user/org) in <header>.

@jekyll jekyll locked and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants