update GitHub Pages domain suffix to github.io#128
Closed
inntran wants to merge 1 commit intojekyll:masterfrom
Closed
update GitHub Pages domain suffix to github.io#128inntran wants to merge 1 commit intojekyll:masterfrom
inntran wants to merge 1 commit intojekyll:masterfrom
Conversation
ghost
approved these changes
Jun 3, 2018
Author
|
I checked the failed test, run script/cibuild locally on macOS 10.13, with Ruby 2.5.1, no errors. |
Member
|
This is a legacy fallback! Check the value of that array. It's all possible domains. For non-Enterprise users, that includes |
Author
|
I understand. The reason I thought it was an issue: on local setup, it's recognized as a project_page, but on GitHub.com it's correctly recognized as a user_page, showing different links(project vs user/org) in <header>. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitHub has moved from .com to .io to host gh-pages, https://blog.github.com/2013-04-05-new-github-pages-domain-github-io/
It makes sense to update here as well.