Code cleanup and migration to Python 3 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he method's argument
Reported by wolfy1339 here: 9c5bef9#commitcomment-18462108
Reported and fixed by philsmd here: iphelix#1 (I couldn't just pull his fix due to my modifications)
When using the --threads flag, the script doesn't end, because it is waiting for cpu_count() threads (which is never satisfied).
Fix bug when threads != cpu_count
'x' has been replaced with 'O' and the new functionality of 'x' has been added.
shabang python3
|
it's too bad this got so out of date :-( |
|
Indeed, would love to see an update where policy masks are statistically arranged. |
Fixed 'x' and 'O' rules
Author
|
@cornfeedhobo @whoot out of curiosity, what features are missing exactly/what should be updated? |
|
hydraze thank you so much for this, you're a bloody legend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR contains massive code cleanup (code is now nearly PEP8 compliant) and modifications to make it work with Python 3. I tested many features but I may have missed something.