added slider width attribute to slide box #2529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can already do this with CSS by setting the width of the |
Author
|
I'll have to try it out but I didn't see any code that would make that work when I was writing this. Why was it an open feature request on trello as well if you could already do it? |
|
i don't understand where i have to write this attribute... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to feature request/issue #2424
This adds a "slider-width" attribute to a slide box which can take a value between 0 and 1 (representing 0-100%).
The next/prev slides will be partially visible if anything other than 1 is set.
Defaults to 1 (100%).