You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To support debugging a challenging remote ID test report, I added a mechanism to render two new types of queries (RID injection "create test" and F3411-22a "search flights") to those which generate KML content for the sequence view artifact.
A few small issues noticed during this work are also cleaned up:
Remove log statements that incorrectly suggest a problem to the user
Close a formatting tag in documentation (resulting in the mentioned requirement showing up in autogenerated test suite documentation)
Fix a word ("can" -> "cannot") in documentation
basedpyright does not like the clever(?) feature of the QueryKMLRenderer Protocol which allows one or more of the specified arguments to be omitted with defined behavior when that happens (see query_kml_renderer decorator documentation), so two new items are added to the baseline.json backlog. I also added a Make target to make additions/exceptions like this easier to manage. Suggestions for ways to avoid these findings entirely are welcome (e.g., more accurate typing on QueryKMLRenderer or elsewhere).
basedpyright does not like the clever(?) feature of the QueryKMLRenderer Protocol which allows one or more of the specified arguments to be omitted with defined behavior when that happens (see query_kml_renderer decorator documentation), so two new items are added to the baseline.json backlog.
Shouldn't we use ignore statements for that? I would say that baseline is for the baseline, created at the start, and ignore is when we processed it and there are no others solutions.
Suggestions for ways to avoid these findings entirely are welcome
I tried some solution, it seems that "cheating" is not possible on Protocol side. On the typing side, those function may be called with all arguments and all of them must be supported.
Solution is either to switch to a generic callable (Callable[..., list[kml.Element]]) or to add defaults to all decorated functions :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support debugging a challenging remote ID test report, I added a mechanism to render two new types of queries (RID injection "create test" and F3411-22a "search flights") to those which generate KML content for the sequence view artifact.
A few small issues noticed during this work are also cleaned up:
basedpyright does not like the clever(?) feature of the QueryKMLRenderer Protocol which allows one or more of the specified arguments to be omitted with defined behavior when that happens (see query_kml_renderer decorator documentation), so two new items are added to the baseline.json backlog. I also added a Make target to make additions/exceptions like this easier to manage. Suggestions for ways to avoid these findings entirely are welcome (e.g., more accurate typing on QueryKMLRenderer or elsewhere).