[uss_qualifier] Improve check-matching#1380
Merged
mickmis merged 1 commit intointeruss:mainfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, whether a check will match a specified check is somewhat vague. This PR improves the documentation regarding what is expected for the values of a FullyQualifiedCheck, but also improves TestScenarioTypeName comparisons. Previously, a test scenario name would only match if the exact same form of its name was used. For instance,
scenarios.astm.utm.dss.dss_interoperability.DSSInteroperabilitywould NOT matchscenarios.astm.utm.dss.DSSInteroperabilityeven though both of those relative Python paths resolve to the same class because of the shortcut import at thedssmodule level. This PR fixes that by introducingare_scenario_types_equaland using it whenever two TestScenarioTypeNames are compared. This function is not added asTestScenarioTypeName.__eq__because attempting to do so would create a circular reference (TestScenarioTypeName is a definition-level building block whereas the implementation of equality requires machinery defined at thescenarioimplementation level). The success of this change is verified by changing the f3548_self_contained configuration to use a different from of the test scenario name and checking that the finding is still accepted.