Make it easier to dig into large profile results#2
Open
ianawilson wants to merge 1 commit intoiddl:masterfrom
Open
Make it easier to dig into large profile results#2ianawilson wants to merge 1 commit intoiddl:masterfrom
ianawilson wants to merge 1 commit intoiddl:masterfrom
Conversation
- Highlighting for operations which take longer than a given threshold
(default 1000 milliseconds)
- Option to exclude operations which are faster than a given threshold
(default disabled)
- Option to limit the depth of children to display
- 2 levels of verbosity
Fixes
- Aggregations were never displayed because of a variable naming
conflict ("s" for "shards" and "searches")
- All timings correctly converted from nanos to millis
Author
|
Hey @iddl, I wanted to tag you on this, but am not able to add any reviewers. I wanted to see if you'd be open to merging some or all of this; I found it quite helpful in digging through some big ES profiles recently on an AWS-hosted ES, where I can't get the x-pack profiler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I know this project isn't actively maintained, but I found it to be a really useful base and extended it for a project I was working on to dig into performance problems in our elasticsearch cluster.
We had some complex queries and aggregations, so I needed more options to focus and prune the output. The following is all of the additions that I made. I believe all of these changes are backward compatible with any existing uses of the script.
If there is a subset of these that you'd consider including, let me know, and I'd be happy to talk through them.
Additions
Fixes