Skip to content

design: Make service map drill-down links more obvious#1738

Merged
kodiakhq[bot] merged 2 commits intomainfrom
drew/make-service-map-links-more-obvious
Feb 13, 2026
Merged

design: Make service map drill-down links more obvious#1738
kodiakhq[bot] merged 2 commits intomainfrom
drew/make-service-map-links-more-obvious

Conversation

@pulpdrew
Copy link
Contributor

Summary

The buttons within the service map tooltips were hard to recognize as buttons/links. I've added an icon and give them a hover state.

Before

Screenshot 2026-02-13 at 2 28 14 PM

After

Screenshot 2026-02-13 at 2 27 26 PM

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 13, 2026 8:48pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Latest commit: aa7c63a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link

claude bot commented Feb 13, 2026

PR Review

Button variant violation → Replace variant="subtle" with allowed variants per agent_docs/code_style.md:

  • Line 64: Use variant="secondary" for requests button
  • Line 78: Use variant="secondary" for errors button (or consider if this should be variant="danger" given it shows errors)

Invalid color prop → Remove color="var(--color-text)" and color="var(--color-text-danger)"

  • Custom variants handle colors automatically
  • CSS variables should not be passed directly to Button color prop

⚠️ Unused imports → Remove unused Group and UnstyledButton imports (ServiceMapTooltip.tsx:4)


Note: The project strictly requires using only variant="primary", variant="secondary", or variant="danger" for Button components. The subtle variant is not in the allowed list.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

E2E Test Results

All tests passed • 64 passed • 4 skipped • 851s

Status Count
✅ Passed 64
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew requested review from a team, bot-hyperdx and dhable and removed request for a team and bot-hyperdx February 13, 2026 20:00
@kodiakhq kodiakhq bot merged commit 69f0b48 into main Feb 13, 2026
12 of 14 checks passed
@kodiakhq kodiakhq bot deleted the drew/make-service-map-links-more-obvious branch February 13, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants