Fixing issue with doryd service not coming up #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@imran-ansari @wdurairaj @sneharai4 @prablr79 Kindly review |
| section: Service | ||
| option: ExecStart | ||
| value: /usr/libexec/kubernetes/kubelet-plugins/volume/exec/hpe.com~hpe/doryd /etc/origin/master/admin.kubeconfig hpe.com | ||
| when: services_state['ansible_facts']['services']['doryd.service']['state'] == "stopped" |
Collaborator
There was a problem hiding this comment.
Can there be a possible race condition between the two attempts to start the service?
E.g. the admin.conf, is good and the service is about to come up but the state is still "stopped" so the attempt to start service with admin.kubeconfig is also made. Is some sleep or wait required between the two attempts? Please check.
farhan7500
commented
Apr 23, 2019
| daemon_reload: yes | ||
| enabled: yes | ||
| name: doryd.service | ||
| when: services_state['ansible_facts']['services']['doryd.service']['state'] == "stopped" |
Contributor
Author
There was a problem hiding this comment.
We need to check against started rather than stopped
farhan7500
commented
Apr 23, 2019
| path: /etc/systemd/system/doryd.service | ||
| section: Service | ||
| option: ExecStart | ||
| value: /usr/libexec/kubernetes/kubelet-plugins/volume/exec/hpe.com~hpe/doryd /etc/origin/master/admin.kubeconfig hpe.com |
Contributor
Author
There was a problem hiding this comment.
Stopgap fix. The long term fix would be to understand which config file works for which version of openshift/kubernetes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.