switch to github actions, kill travis#41
Open
andreineculau wants to merge 2 commits intohawk:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong, but I think
make testhas been failing since version 1.12 , dated 2016-02-23. Since then tests have been failing for different reasons as seen here per each tag https://github.com/andreineculau/lux/actionsThis PR is in fact the same setup as used in https://github.com/for-GET/katt and https://github.com/for-GET/jesse , based on the official OTP Docker images. A pre-step is needed to get git 2.18, because actions/checkout@v2 behaves differently otherwise - complete info is here erlang/docker-erlang-otp#351 .
Since the tests are red, I have disabled the OTP matrix, except for the latest OTP version, in order to save resources. When tests are green, one can
git revert --no-edit 6f2c3bato enable the matrix again. Similarly, one could/should enableLUX_MISCto run doc&misc tests in CI.