-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: 🐛 allow typed server methods access cache methods #4515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fix a pre typing issue? Can you elaborate? To me it reads like you created an issue with this PR. |
|
@kanongil I like the strong typing, but for practical purposes, you can't use utilities that don't carry the same If you run it locally, observe the type test: In the current state of typings, where one is used as a utility ( If you have other ideas, that'd be great, cause I agree that this is sub-optimal. |
90bea73 to
e63d51e
Compare
also fix pre typing issue fix: 🐛 reflect reality of Hapi methods in types
e63d51e to
d60f5dc
Compare
Marsup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixing formatting issues
also fix pre typing issuewould be fixed by #4489 . Change removed.