Open
Conversation
monzchan
suggested changes
Aug 20, 2025
|
|
||
|
|
||
| SELECT | ||
| customer_id, market_date, DENSE_RANK() OVER ( PARTITION BY customer_id ORDER BY market_date ) AS visit_number FROM ( SELECT DISTINCT customer_id, market_date FROM customer_purchases |
There was a problem hiding this comment.
Using DISTINCT here reduces multiple purchases on the same day. Usually, for a COUNT window function, you shouldn’t use DISTINCT, because it alters the window calculation.
Owner
Author
There was a problem hiding this comment.
Thanks for the comment. Changed it
| select vendor_name,product_name,sum(original_price*5*customer_count) total_revenue from | ||
| ( | ||
| select distinct v.vendor_name,p.product_name,original_price from vendor v | ||
| cross join vendor_inventory vi on v.vendor_id = vi.vendor_id |
There was a problem hiding this comment.
This might not be a valid syntax. CROSS JOIN doesn't have an ON/
Use JOIN for vendor to inventory, then cross join customer count
Owner
Author
There was a problem hiding this comment.
this happened by mistake and I fixed it
Owner
Author
|
New commit has been pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
delivering assignment two
What did you learn from the changes you have made?
building logical model and SQL
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
no
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
no challenges
How were these changes tested?
by running those SQL commands in SQLite
A reference to a related issue in your repository (if applicable)
not applicable
Checklist