Update to dotnet-core branch to be up-to-date with master branch #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Made easier to override by bring it up to the ParserSettings class. Added ParserSettings.MaximumDisplayWidth property that will be passed to HelpText Added maxDisplayWidth params to several methods with a default of DefaultMaximumLength if not provided Added an attempt to set the MaximumDisplayWidth in ParserSettings and HelpText to Console.WindowWidth and if it isn't possible use MaximumDisplayWidth instead.
Defaults to current consoles width if available otherwise uses default. Made easier to override by bring it up to the ParserSettings class.
The attribute Hidden has been added to OptionAttribute, ValueAttribute, and VerbAttribute. By default it is false. Changes to support this new attribute so that if hidden it is not visible in the help text, but is still usable if called correctly. If you ask for help on a hidden verb you will get the help displayed but hidden options will still be hidden. Allowing for hidden verbs with not hidden options. Resolves issue #263
Previous behavior split the incoming token long-name value using the equal sign as the separator. This would cause an option's value containing spaces to get truncated. New behavior does regex. match to make sure format is correct and gets the full value.
…tion-value Allow spaces when tokenizing option-value
Implemented Hidden Verbs, Options and Values
Fixed typo.
Newer tools require some config changes. xUnit also has incompatibilities with .Net 4.0 assemblies.
Also changed IList<Attribute> to IEnumerable<Attribute>.
…erence Fix for missing author null reference (#332)
fix outdated README section under csharp with working example.
Update README.md
This reverts commit 4e15d55.
This reverts commit d4e0b25.
Add unit tests for TypeConverter for scalars (only). Add DotSettings.user to .gitignore.
Fix for invalid cast when specifying true or false for int option (#339)
Collaborator
|
I'm pretty sure I merged everything in the dotnet-core branch back into master, but if anything this merge should be going the other way: This branch will be deleted soon now that master has support for .net core, so I won't merge this. Have you noticed anything I should merge back into master? |
Author
|
@nemec Sorry, I didn't know the support is already there on master, as the readme says otherwise. Can we close / merge down this one and update the readme then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.