Closed
Conversation
Member
|
I'm sorry, I don't quite understand what the output of TSGraphQL is meant to be. Is that TS code which, when run, will produce a GraphQL schema? In that case, why not produce the GraphQL schema right away? Other than that, it looks ok so far, from a quick glance. The package updates should be a separate PR, though, unless they're required for this target language. And please don't include the yarn file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
definitly not working for now.
But I would appreciate some feedback if I on the right route.
thx in advance
meno