This repository was archived by the owner on Jun 21, 2023. It is now read-only.
2.7.x-github #1
Open
2.7.x-github #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Puppet just spits File content diffs at the notice loglevel regardless of what we've told it. That's a bit silly, considering we've already told Puppet we may want another loglevel for a particular resource. This fixes that behavior.
File content diff with show_diff respects loglevel
wfarr
pushed a commit
that referenced
this pull request
Mar 4, 2014
…to-console'" This reverts commit 8d99bcb, reversing changes made to 7d6515f. This change had two unintended side effects: 1) 20900 tagmail from 'puppet agent --onetime' run as a cron job begins sending additional emails of verbose logs. 2) 20919 cron job of 'puppet agent --onetime --no-daemonize' produces additional verbose logs to both console and syslog. Issue #1 occured because the 15187 patch caused agent log level to switch to info by default. Issue #2 was due to the above log level issue, and the fact that by default a console logger was also opened for all agents, which does not get closed if --no-daemonize is specified. Reverting fixes both of these unintended logging issues by returning to the logging behavior seen in 3.1.1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion only. Do not merge.