Skip to content

Code review: inconsistent thicknesses scale definition #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: legend
Choose a base branch
from
Open

Code review: inconsistent thicknesses scale definition #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2be37fc
Initial plan
Copilot Dec 9, 2025
2675a8e
Fix thicknesses scale to use transform instead of scalepoint
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions specs/1.3.1/_viz.rnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,22 @@ sizes-scale-content = scale-label-attribute?
}
thicknesses-scale-content = scale-label-attribute?
& attribute scale {"quantitative"}
& element scalepoint {
for-ratio-attribute
& attribute factor {xsd:float}
}*
& element transform {
(element pow { attribute exponent {xsd:integer}}|
element sqrt {empty}|
element log {empty}|
element log10 {empty}|
element exp {empty}|
element exp10 {empty}|
element spline {
element origin-control-point {
control-point-content
},
element destination-control-point {
control-point-content
}
})
}
& element range {
attribute min { thickness-type },
attribute max { thickness-type },
Expand Down
40 changes: 31 additions & 9 deletions specs/1.3.1/_viz.rng
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,16 +318,38 @@
<attribute name="scale">
<value>quantitative</value>
</attribute>
<zeroOrMore>
<element name="scalepoint">
<interleave>
<ref name="for-ratio-attribute"/>
<attribute name="factor">
<data type="float"/>
<element name="transform">
<choice>
<element name="pow">
<attribute name="exponent">
<data type="integer"/>
</attribute>
</interleave>
</element>
</zeroOrMore>
</element>
<element name="sqrt">
<empty/>
</element>
<element name="log">
<empty/>
</element>
<element name="log10">
<empty/>
</element>
<element name="exp">
<empty/>
</element>
<element name="exp10">
<empty/>
</element>
<element name="spline">
<element name="origin-control-point">
<ref name="control-point-content"/>
</element>
<element name="destination-control-point">
<ref name="control-point-content"/>
</element>
</element>
</choice>
</element>
<element name="range">
<attribute name="min">
<ref name="thickness-type"/>
Expand Down
Loading