Skip to content

Conversation

@Jenyyk
Copy link

@Jenyyk Jenyyk commented Nov 30, 2024

Pretaining to #26
PROS:

  • it works during usage (while not switching modes)

CONS:

  • when switching between blacklist / whitelist, does not automatically update the effect 4d1d51c
    • needs to be somehow kickstarted, eg. by flipping around the skip LibAdwaita/LibHandy buttons
  • when switching between blacklist / whitelist, sometimes freezes my computer

@Jenyyk
Copy link
Author

Jenyyk commented Dec 17, 2024

4 new commits to address all requested changes

@Jenyyk Jenyyk requested a review from flexagoon December 17, 2024 11:58
@GrzegorzKozub
Copy link

Ghostty uses LibAdwaita and has rounded corners already. But when we disable window decorations in Ghostty then rounded corners are no longer applied.

This extension has a nice feature of skipping LibAdwaita apps. When we disable it, then it applies the rounded corners to Ghostty running without its own window decorations.

Does this change enable a scenario where we can keep the LibAdwaita skip enabled and still whitelist Ghostty to round its corners when it doesn't use window decorations?

@Jenyyk
Copy link
Author

Jenyyk commented Apr 16, 2025

Does this change enable a scenario where we can keep the LibAdwaita skip enabled and still whitelist Ghostty to round its corners when it doesn't use window decorations?

91f3d98 Now it does!
Although i dont see how you would use this, as the whitelist only rounds the corners of apps inside it, which makes the skip LibAdwaita/LibHandy choices useless, since you can just... not add those apps to the whitelist?
I believe you are looking for a different type of whitelist. This whitelist skips EVERYTHING that is NOT inside it.
Regardless the whitelist now overrides the skip LibAdwaita/LibHandy buttons

@GrzegorzKozub
Copy link

Thanks! Looked deeper into Ghostty config and it turns out that if you set gtk-titlebar = false you retain the native rounded corners.

@JLBlk
Copy link

JLBlk commented May 2, 2025

This would really be a game changer for me, since vs code is the only app i currently have that still has squared corners. Hope this gets added soon

@MysteriousGitEntity
Copy link

What is preventing this pull request from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants