Open
Conversation
This reverts commit bb34763.
Add support for Brave cookies.
Support Slack app cookies
Revert "Support Slack app cookies"
I'm not clear if I've been getting any benefit from splitting `dev` and `master` branches all these years, so giving a shot to just using `master` directly.
Must now be a variant of the `BrowserType` enum
`get_cookies` calls out to `chrome_cookies` or `firefox_cookies` based on `browser`. Because `browser` needs to be specified anyway, this should make it easier for users to have a single entrypoint. As part of this refactor I changed argument order to be more similar between the two browser-specific functions and required everything other than `url` to be keyword-only, to reduce ambiguity, which required some changes in the Firefox tests.
When _not_ explicitly requesting a specific Firefox profile directory the default profile is chosen. However on top of profiles Firefox may have multiple "installs" (listed in the `installs.ini` file) each with their own default profile. Before, the default profile was the one from the first install. However, it makes more sense to pick the last one instead, assuming that that's the most recently created one, and thus the active one.
A previous commit added support for when Slack is installed through the App Store. Alas, it broke support for non-App Store situations! This commit restores non- App Store support, while retaining the support for App Store scenarios.
Restore non-App Store support for Slack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )