Open
Conversation
Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
See PR containerd/containerd#7839 and commit 34d587818596 ("Use mount.Target to specify subdirectory of rootfs mount") for more details. Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
So that
$ nerdctl run --snapshotter=erofs -it --rm docker.1ms.run/library/nginx:latest /bin/sh
can work now instead of erroring out as:
```
FATA[0000] failed to mount {Type:format/mkdir/overlay Source:overlay Target: Options:[lowerdir={{ overlay 0 6 }}]} on "/tmp/initialC2844197147": mount source: "overlay", target: "/tmp/initialC2844197147", fstype: format/mkdir/overlay, flags: 0, data: "lowerdir={{ overlay 0 6 }}", err: no such device
```
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
bump to containerd v2.2.0-rc.0
Add support for mount manager
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
update runc (1.3.2), BuildKit (0.25.1), stargz-snapshotter (0.18.0), etc.
Bumps [github.com/containerd/containerd/v2](https://github.com/containerd/containerd) from 2.2.0-rc.0 to 2.2.0-rc.1. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v2.2.0-rc.0...v2.2.0-rc.1) --- updated-dependencies: - dependency-name: github.com/containerd/containerd/v2 dependency-version: 2.2.0-rc.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….com/containerd/containerd/v2-2.2.0-rc.1 build(deps): bump github.com/containerd/containerd/v2 from 2.2.0-rc.0 to 2.2.0-rc.1
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 5.8.0 to 5.9.0. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@c1e5197...318604b) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-version: 5.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…cker/metadata-action-5.9.0 build(deps): bump docker/metadata-action from 5.8.0 to 5.9.0
Signed-off-by: Shubhranshu Mahapatra <shubhum@amazon.com>
Upgrade runc to v1.3.3
Bumps the docker group with 2 updates: [github.com/docker/cli](https://github.com/docker/cli) and [github.com/docker/docker](https://github.com/docker/docker). Updates `github.com/docker/cli` from 28.5.1+incompatible to 28.5.2+incompatible - [Commits](docker/cli@v28.5.1...v28.5.2) Updates `github.com/docker/docker` from 28.5.1+incompatible to 28.5.2+incompatible - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v28.5.1...v28.5.2) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 28.5.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker - dependency-name: github.com/docker/docker dependency-version: 28.5.2+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@2910929...c7c5346) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/containerd/containerd/v2](https://github.com/containerd/containerd) from 2.2.0-rc.1 to 2.2.0. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v2.2.0-rc.1...v2.2.0) --- updated-dependencies: - dependency-name: github.com/containerd/containerd/v2 dependency-version: 2.2.0 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…-12cc96b89b build(deps): bump the docker group with 2 updates
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…cker/setup-qemu-action-3.7.0 build(deps): bump docker/setup-qemu-action from 3.6.0 to 3.7.0
….com/containerd/containerd/v2-2.2.0 build(deps): bump github.com/containerd/containerd/v2 from 2.2.0-rc.1 to 2.2.0
update containerd (2.2.0), BuildKit (0.25.2), containerd-fuse-overlayfs (2.1.7)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Bumps [docker/login-action](https://github.com/docker/login-action) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@5e57cd1...c94ce9f) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 5.0.2 to 5.0.3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@8b402f5...cdf6c1f) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](actions/attest-build-provenance@00014ed...96278af) --- updated-dependencies: - dependency-name: actions/attest-build-provenance dependency-version: 3.2.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/checkout-6.0.2 build(deps): bump actions/checkout from 6.0.1 to 6.0.2
….com/containerd/nydus-snapshotter-0.15.11 build(deps): bump github.com/containerd/nydus-snapshotter from 0.15.10 to 0.15.11
….com/coreos/go-systemd/v22-22.7.0 build(deps): bump github.com/coreos/go-systemd/v22 from 22.6.0 to 22.7.0
…tions/cache-5.0.3 build(deps): bump actions/cache from 5.0.2 to 5.0.3
…cker/login-action-3.7.0 build(deps): bump docker/login-action from 3.6.0 to 3.7.0
…tions/attest-build-provenance-3.2.0 build(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0
Signed-off-by: Hajime Ogi <robertcal900@gmail.com>
Signed-off-by: Hajime Ogi <robertcal900@gmail.com>
The docs already documented `--ipc=(host|private|shareable|container:<container>)`. - https://github.com/containerd/nerdctl/blob/main/docs/command-reference.md#whale-nerdctl-run However, the implementation only had `host` and `private` in help text and completion. This adds the missing options and smart completion for `container:<name>` Signed-off-by: Hayato Kiwata <dev@haytok.jp>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
…er_windows_test.go test: refactor container_run_user_windows_test.go to use Tigron
…er_linux_test.go test: refactor container_run_user_linux_test.go to use Tigron
…t_windows_test.go test: refactor container_inspect_windows_test.go to use Tigron
…_test.go test: refactor compose_port_linux_test.go to use Tigron
Bumps the docker group with 1 update: [github.com/docker/cli](https://github.com/docker/cli). Updates `github.com/docker/cli` from 29.1.5+incompatible to 29.2.0+incompatible - [Commits](docker/cli@v29.1.5...v29.2.0) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.2.0+incompatible dependency-type: direct:production update-type: version-update:semver-minor dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
…-812415d43e build(deps): bump github.com/docker/cli from 29.1.5+incompatible to 29.2.0+incompatible in the docker group
When running nerdctl without any command, the usage text incorrectly showed "Usage: nerdctl [flags]" instead of "Usage: nerdctl [command]". This happened because the usage function checked c.Runnable() to decide the format, but the root command has RunE set (for handling unknown subcommands), making it "runnable" even though it semantically requires a subcommand. The fix prioritizes checking HasSubCommands() first, which correctly displays "[command]" for commands that have subcommands, regardless of whether they also have a Run function defined. Fixes #3185 Signed-off-by: Nivesh Dandyan <niveshdandyan@gmail.com>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Bumps the docker group with 1 update: [github.com/docker/cli](https://github.com/docker/cli). Updates `github.com/docker/cli` from 29.2.0+incompatible to 29.2.1+incompatible - [Commits](docker/cli@v29.2.0...v29.2.1) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.2.1+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
…-81a0a61577 build(deps): bump github.com/docker/cli from 29.2.0+incompatible to 29.2.1+incompatible in the docker group
fix: correct usage display to show [command] instead of [flags]
fix: add missing --ipc options in help text and shell completion
…_windows_test.go test: refactor container_remove_windows_test.go to use Tigron
…ndows_test.go test: refactor container_run_windows_test.go to use Tigron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )