Closed
Conversation
added 2 commits
November 26, 2013 19:46
Added MoneySetEvent ignite.
Member
|
Why would you want an event firing here? |
Contributor
Author
|
Because it's moneySet method. It would be best place for scoreboards plugin, isn't it? I suppose it's best place, if no, please correct me. |
Member
|
This code isn't executed if you have another economy plugin. Is that what you would want? |
Contributor
Author
|
Yes, to optimize Scoreboard plugins it's perfect. I don't like task, which is running every xx ticks. |
Member
Member
|
As long as you know it will be triggered by other plugins, not just from Essentials signs/commands. |
Member
|
Wouldn't you want a money changed event, not a set event? |
Member
|
Never mind, I just read the code :> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.