[pull] main from temporalio:main #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changed? Add RateLimitedScheduler to the outbound task processor. ## Why? Add task processing queues, except the outbound task queue uses RateLimitedScheduler. Adding this helps to make sure that the rate limit is applied on the caller namespace. ## How did you test it? - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
## What changed? - There is a chance that the errors slice of a *serviceerror.MultiOperationExecution pointer contains nil errors. Right now, in the workerdeployment code, we were not handling that. ## Why? - To fix things. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks - None <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Prevents nil error entries from breaking retry logic during multi-operation updates. > > - In `service/worker/workerdeployment/util.go`, `isRetryableUpdateError` now skips `nil` items in `errMultiOps.OperationErrors()` before checking for `ResourceExhausted`, `ErrWorkflowClosing`, or `AbortedByServerErr` conditions > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4f8f94f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Overview This commit implements two new granular timeout types for Nexus operations, allowing callers to have fine-grained control over different phases of operation execution: - **Schedule-to-Start Timeout**: Maximum time to wait for an operation to be started (or completed if synchronous) by the handler - **Start-to-Close Timeout**: Maximum time to wait for an asynchronous operation to complete after it has been started These timeouts complement the existing **Schedule-to-Close Timeout** to provide better control and diagnostics for Nexus operation execution. See the corresponding API PR: temporalio/api#695.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )