[pull] main from temporalio:main #474
Merged
+99
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds compatibility (#8991) ## What changed? Ignore unknown fields when decoding Worker Deployment memo for backwards compatibility ## Why? New field was added to memo. We want to be able to roll back server and still list deployments, just without that field ## How did you test it? Tested it with v148. Also cherry-picked onto v147.6 and ran my unit test. With the new Lenient converter, the unit test passed as expected. With the old strict converter, the unit test failed as expected. - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s) ## Potential risks Changing the data converter is risky, but in this case, we know we are decoding a proto, and we have tests covering that decoding, so I think it's ok <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Makes JSON/protobuf memo decoding lenient to support backward compatibility and adds tests to verify decoding behavior. > > - Update `PreferProtoDataConverter` to use `NewProtoJSONPayloadConverterWithOptions(AllowUnknownFields: true)`, causing proto JSON decoding to ignore unknown fields > - Add `TestDecodeWorkerDeploymentMemoTolerateUnknownFields` and `TestDecodeWorkerDeploymentMemoTolerateMissingFields` with memo JSON fixtures to validate `DecodeWorkerDeploymentMemo` succeeds and parses known fields > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a0d1ea4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )